removed default empty string that causes validation errors

agorapulse · Dec 12, 2023 · 67bd302 · 67bd302
1 parent 5c40612
commit 67bd302
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/...ain/java/com/agorapulse/micronaut/amazon/awssdk/s3/SimpleStorageServiceConfiguration.java b/...ain/java/com/agorapulse/micronaut/amazon/awssdk/s3/SimpleStorageServiceConfiguration.java
@@ -68,7 +68,7 @@ public void setPathStyleAccessEnabled(Boolean forcePathStyle) {
     }
 
     @Size(min = 1)
-    private String bucket = "";
+    private String bucket;
     private Boolean forcePathStyle;
 
 }
diff --git a/...-kinesis/src/main/groovy/com/agorapulse/micronaut/aws/kinesis/KinesisConfiguration.groovy b/...-kinesis/src/main/groovy/com/agorapulse/micronaut/aws/kinesis/KinesisConfiguration.groovy
@@ -29,7 +29,7 @@ import jakarta.validation.constraints.Size
 @SuppressWarnings('AbstractClassWithoutAbstractMethod')
 abstract class KinesisConfiguration extends DefaultRegionAndEndpointConfiguration {
 
-    @Size(min = 1) String stream = ''
+    @Size(min = 1) String stream
 
     String consumerFilterKey = ''
 

diff --git a/.../src/main/groovy/com/agorapulse/micronaut/aws/s3/SimpleStorageServiceConfiguration.groovy b/.../src/main/groovy/com/agorapulse/micronaut/aws/s3/SimpleStorageServiceConfiguration.groovy
@@ -19,7 +19,6 @@ package com.agorapulse.micronaut.aws.s3
 
 import com.agorapulse.micronaut.aws.DefaultRegionAndEndpointConfiguration
 import groovy.transform.CompileStatic
-
 import jakarta.validation.constraints.Size
 
 /**
@@ -29,7 +28,7 @@ import jakarta.validation.constraints.Size
 @SuppressWarnings('AbstractClassWithoutAbstractMethod')
 abstract class SimpleStorageServiceConfiguration extends DefaultRegionAndEndpointConfiguration {
 
-    @Size(min = 1) String bucket = ''
+    @Size(min = 1) String bucket
     Boolean pathStyleAccessEnabled
 
 }
diff --git a/...k-s3/src/test/groovy/com/agorapulse/micronaut/aws/s3/SimpleStorageServiceMinioSpec.groovy b/...k-s3/src/test/groovy/com/agorapulse/micronaut/aws/s3/SimpleStorageServiceMinioSpec.groovy
@@ -28,6 +28,7 @@ import java.time.Duration
  * Tests for SimpleStorageService based on Testcontainers with Minio server.
  */
 @Property(name = 'aws.s3.path-style-access-enabled', value = 'true')
+@Property(name = 'aws.s3.bucket', value = MY_BUCKET)
 class SimpleStorageServiceMinioSpec extends SimpleStorageServiceSpec implements TestPropertyProvider {
 
     private static final int MINIO_PORT = 9000