[sc115424] add send messages by batch to sqs sdk

[mtakerrabet]

add send messages by batch to to an aws sqs queue

[shortcut-integration]

This pull request has been linked to Shortcut Story #115424: add send messages by batch to micronaut aws sqs sdk.

[musketyr]

looks good, just a minor thing: I think using the messagesList for a Map is not a good practice. can you rename it.

I think it would make sense to to also add the support into @QueueClient declarative clients. e.g. by using @Batch on a Map<String, Object> parameters, what do you think?

another subject is if there is a need to backport the change also into AWS SDK v1 library. so far we were trying to keep these in sync.

[mtakerrabet]

looks good, just a minor thing: I think using the messagesList for a Map is not a good practice. can you rename it.

I think it would make sense to to also add the support into @QueueClient declarative clients. e.g. by using @Batch on a Map<String, Object> parameters, what do you think?

another subject is if there is a need to backport the change also into AWS SDK v1 library. so far we were trying to keep these in sync.

Hi @musketyr, thanks for the review, I renamed the parameter and did the modification for the @QueueClient declarative clients client, but I didn't the changes on the AWS SDK v1 library, the SendMessageBatchRequest is provided by the software.amazon.awssdk:sqs which is not embedded in

[musketyr]

@mtakerrabet please, check this update to your PR: cd862c2.

So the number of messages in the batch has its hard limit? In that case we can partition the messages directly in the introduced method.

[mtakerrabet]

@mtakerrabet please, check this update to your PR: cd862c2.

So the number of messages in the batch has its hard limit? In that case we can partition the messages directly in the introduced method.

Thank you for the updates @musketyr, it looks good to me,
and for the number of messages in the batch, yes, sqs set a hard limit to 10 messages by request