Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom ok hander (#171) + cleanup, docs, and tests #194

Merged
merged 7 commits into from
Jun 10, 2018

Conversation

nason
Copy link
Collaborator

@nason nason commented Jun 10, 2018

Picks up from @iamandrewluca's #171 and:

  • rebases from + targets next branch
  • adds tests
  • adds docs
  • adds error handling around ok function

Andrew Luca and others added 4 commits June 10, 2018 13:56
Thanks to @iamandrewluca

Keep same signature

Export createMiddleware

Export defaults into separate file

Explicit export createMiddleware

Add local ok handler, take fetch from createMiddleware

Now user can provide a global ok/fetch handler or a local ok/fetch handler
Local ok/fetch handler will take priority
@nason nason added this to the 3.0.0 milestone Jun 10, 2018
@coveralls

This comment has been minimized.

@nason nason force-pushed the custom-error-evaluation-docs-tests branch from 42c342d to ce5e2f3 Compare June 10, 2018 18:12
@nason nason changed the title Custom error evaluation docs tests Add custom ok hander (#171) + cleanup, docs, and tests Jun 10, 2018
@nason nason mentioned this pull request Jun 10, 2018
7 tasks
@nason nason merged commit 3a19b1b into next Jun 10, 2018
@nason nason deleted the custom-error-evaluation-docs-tests branch June 17, 2018 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants