Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we need to think if we do a pull request of the /synchronize_groups with slices #272

Closed
syphax-bouazzouni opened this issue May 23, 2022 · 3 comments
Assignees
Labels

Comments

@syphax-bouazzouni
Copy link
Contributor

syphax-bouazzouni commented May 23, 2022

With ncbo/ontologies_api#87 we will sync with the upstream still just to discuss if we need also the share synchronize_groups feature (https://data.agroportal.lirmm.fr/synchronize_groups)

@jonquet jonquet self-assigned this May 23, 2022
@jonquet
Copy link
Contributor

jonquet commented May 23, 2022

Feature

Update all slices to match the groups of the current appliance: create a new slice with the same parameters as the group if not existing, update the ontologies of the slice to match the ontologies of the group if already existing.
API Key of an administrator account required.
curl -X GET
-H "Content-Type: application/json"
-H "Authorization:apikey token=$APIKEY"
http://data.agroportal.lirmm.fr/slices/synchronize_groups

This feature was implemented by @vemonet to facilitate slice management after we took the "design" choice of having slice and groups aligned in AgroPortal (basically: slice are built out of ontologies that are in a group). We found it was more simple for users.

@jvendetti @mdorf @graybeal @stdotjohn any thoughts ?

@graybeal
Copy link

graybeal commented May 23, 2022

I think that's a good design choice, it's much easier to understand.

I assume it eliminates the ability to use a group orthogonally to a slice you were in We'd have to double-check on BioPortal what slices are not synchronized to the same-named group and if any, see if we can tell why that is or who would care. It will be unfortunate if a hardcore user sees a critical-to-them feature disappear, but maybe we'll get lucky and no conflicts exist.

@syphax-bouazzouni
Copy link
Contributor Author

Done in ontoportal/ontologies_api#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants