Feature/gitrepository #52
Conversation
|
Hi, |
Done |
| extra_env = author_info.get_author_env() if author_info else None | ||
| def _commit(self, msg, args=[], author_info=None, committer_info=None): | ||
| extra_env = author_info.get_author_env() if author_info else {} | ||
| if committer_info: |
There was a problem hiding this comment.
If we change from None to {} here we need to fixup _build_env to return None for extra_env being {} or None
|
I spotted one other change that might introduce problems since __build_env would change return type and that gets passed to Popen and Popen's default type for "do nothing" is None not {} (see _execute_child in subprocess.py). I don't think that matter but it might be worth checking. |
Well spotted :) It won't make any difference as the current env is copied in this case. An empty dict is already used in some places, e.g. add_files(). However, I now added one more commit so that extra_env={} will be handled as expected. |
marquiz
force-pushed
the
feature/gitrepository
branch
from
fba3864
to
41faf1d
Compare
marquiz
force-pushed
the
feature/gitrepository
branch
3 times, most recently
from
437b9e7
to
ea3952f
Compare
For setting the committer name/email/date - similarly to author_info. Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
For setting the committer name/email/date - similarly to author_info. Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
No need to build 'env' arg for popen when extra_env is empty. In some methods an empty dict is used to indicate "no extra env". This commit does not affect the output/outcome of GitRepository operations, but, just makes the code a tiny bit sleeker. Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
marquiz
force-pushed
the
feature/gitrepository
branch
from
ea3952f
to
831aeaf
Compare
No description provided.