Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document don't load in Safari #67

Closed
abelsromero opened this issue Jun 22, 2021 · 4 comments
Closed

Document don't load in Safari #67

abelsromero opened this issue Jun 22, 2021 · 4 comments

Comments

@abelsromero
Copy link

Same url working fine in other browsers (Firefox & Chrome) does not load in Safari.
A white screen is shown and the following error appears in the console.

image
@ahus1
Copy link
Owner

ahus1 commented Jun 22, 2021

This might be this problem: sindresorhus/normalize-url#105
I'll investigate

ahus1 added a commit that referenced this issue Jun 22, 2021
@ahus1
make compatible with Safari to avoid "invalid regular expression: inv…
979883c 
…alid group specifier name" (#67)
@ahus1
Copy link
Owner

ahus1 commented Jun 23, 2021

I found that this is instead related to Asciidoctor Kroki that is not Safari-compatible at the moment.
I'll skip the Asciidoctor Kroki functionality in Safari until this is fixed.

I tested it using a online browser test service successfully. I'll have a new version deployed tomorrow.

asciidoctor/asciidoctor-kroki#225

@ahus1 ahus1 closed this as completed Jun 23, 2021
ahus1 added a commit that referenced this issue Jun 23, 2021
@ahus1
kroki is currently incompatible with Safari (#67)
8f2b584
ahus1 added a commit that referenced this issue Jun 23, 2021
@ahus1
Revert "make compatible with Safari to avoid "invalid regular express…
6ae3e54 
…ion: invalid group specifier name" (#67)"

This reverts commit 979883c.
ahus1 added a commit that referenced this issue Jun 23, 2021
@ahus1
Revert "Revert "make compatible with Safari to avoid "invalid regular…
77118a3 
… expression: invalid group specifier name" (#67)""

This reverts commit 6ae3e54.
ahus1 added a commit that referenced this issue Jun 23, 2021
@ahus1
don't load module if running in safari (#67)
e5b7c60
@ggrossetie
Copy link

@ahus1 I don't have Safari at hand, could you please confirm that asciidoctor/asciidoctor-kroki#228 fixes this issue?

@ahus1
Copy link
Owner

ahus1 commented Aug 24, 2021 •
edited
Loading

Hi @Mogztter - finally found a way to test it for me (as a non-mac owner); got myself a 30 day subscription for an "On-Demand Pass" at https://www.lambdatest.com/ to test this and other things related to Safari.

Works great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ggrossetie @ahus1 @abelsromero