Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING.md: Add Development Practices section, Secrets management, and minor revisions #18

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

RussellJimmies
Copy link
Contributor

Revised contribution guide:

  • Renamed "What this is" to "Overview"
  • Added a Table of Contents
  • Added "Managing Secrets" section to Development Practices
  • Minor corrections

profile/CONTRIBUTING.md Outdated Show resolved Hide resolved
file locally.

1. **Fill in Secrets:** Add environment-specific values (e.g., API keys,
database credentials) to your `.env` file as needed. Ask the DevOps team
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What tool are we talking about here, Vault to access secrets ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Precisely! Would help if I named the tool! 😅

RussellJimmies and others added 2 commits November 14, 2024 09:57
Co-authored-by: Jonathan Lopez <jonathan.lopez.1@ens.etsmtl.ca>
@RussellJimmies RussellJimmies merged commit 2821480 into main Nov 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants