Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a dev, I want to refactor the header component #196

Closed
4 tasks done
Tracked by #186
SamuelPelletierEvraire opened this issue Jul 30, 2024 · 3 comments · Fixed by #297
Closed
4 tasks done
Tracked by #186

As a dev, I want to refactor the header component #196

SamuelPelletierEvraire opened this issue Jul 30, 2024 · 3 comments · Fixed by #297
Assignees
@SamuelPelletierEvraire
Labels
Refactor For refactoring task
Milestone
Version 1.0.0

Comments

@SamuelPelletierEvraire
Copy link
Contributor

SamuelPelletierEvraire commented Jul 30, 2024 •
edited
Loading

Description

Implement the new header.

Prototype

image

Header exemple:

Tasks

Refactor the old header to the new header shown in this picture.

Acceptance Criteria

Additional information

Figma design (Please note that the dimension on the design are not accurate)

https://www.figma.com/design/wZAiODRsAfqa8cAxJtQAYr/Untitled?node-id=0-1&t=jbtVtLENKlvQoKjX-1
@SamuelPelletierEvraire SamuelPelletierEvraire converted this from a draft issue Jul 30, 2024
Open
18 tasks
@SamuelPelletierEvraire SamuelPelletierEvraire added the Refactor For refactoring task label Jul 30, 2024
@Youllou Youllou added this to the Version 1.0.0 milestone Aug 8, 2024
@k-allagbe k-allagbe moved this from Blocked to Todo in FertiScan Sep 5, 2024
@k-allagbe k-allagbe mentioned this issue Oct 4, 2024
Closed
@k-allagbe k-allagbe changed the title (Refactor) Header As a dev, I want to refactor the header component Oct 7, 2024
@k-allagbe

This comment was marked as resolved.

Sign in to view
@ChromaticPanic
Copy link
Contributor

ChromaticPanic commented Oct 21, 2024 •
edited
Loading

#186 (comment)

Our header should incorporate these according to the GC identity program for internal websites
https://www.canada.ca/en/treasury-board-secretariat/services/government-communications/design-standard.html#design
https://www.canada.ca/en/treasury-board-secretariat/services/government-communications/design-standard/government-canada-websites-design-standard-fip.html

image

https://design.canada.ca/common-design-patterns/global-header.html
image

@ChromaticPanic
Copy link
Contributor

After catching up with William and looking at ServiceCFIA the current header is fine Image

@SamuelPelletierEvraire SamuelPelletierEvraire moved this from Todo to In progress in FertiScan Oct 24, 2024
@SamuelPelletierEvraire SamuelPelletierEvraire linked a pull request Oct 24, 2024 that will close this issue
196 as a dev I want to refactor the header component #297
Merged
4 tasks
@SamuelPelletierEvraire SamuelPelletierEvraire moved this from In progress to In review in FertiScan Oct 24, 2024
k-allagbe added a commit that referenced this issue Oct 26, 2024
@k-allagbe
issue #196: remove breakpoint-based variable font sizes
d83c7a7
k-allagbe added a commit that referenced this issue Oct 26, 2024
@k-allagbe
issue #196: remove breakpoint-based variable icon sizes
0cbc3f1
k-allagbe added a commit that referenced this issue Oct 26, 2024
@k-allagbe
issue #196: logo sizes use ResponsiveStyleValue
b12420d
k-allagbe added a commit that referenced this issue Oct 26, 2024
@k-allagbe
issue #196: improve logo breakpoint-based responsiveness
b696dc0
k-allagbe added a commit that referenced this issue Oct 28, 2024
@k-allagbe
issue #196: use useBreakpoints in Header
cdb20aa
k-allagbe added a commit that referenced this issue Oct 28, 2024
@k-allagbe
issue #196: basic tests
5334ada
k-allagbe added a commit that referenced this issue Oct 28, 2024
@k-allagbe
Merge pull request #300 from ai-cfia/196-refactor-header-suggestions
af0bdd6 
issue #196: header component responsiveness suggestions
@github-project-automation github-project-automation bot moved this from In review to Done in FertiScan Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SamuelPelletierEvraire SamuelPelletierEvraire

Labels
Refactor For refactoring task
Projects
FertiScan
Status: Done
Milestone
Version 1.0.0
Development

Successfully merging a pull request may close this issue.

196 as a dev I want to refactor the header component ai-cfia/fertiscan-frontend
4 participants
@Youllou @SamuelPelletierEvraire @ChromaticPanic @k-allagbe