Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #283 : Dashboard #333

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

Youllou
Copy link
Member

@Youllou Youllou commented Nov 19, 2024

Fix : #283

  • Created the dashboard page
  • Added a click event to UserMenu that redirects to /dashboard
  • Created the component InspectionList
  • Created the component InspectionElement
  • Created test files
  • Created a type named InspectionPreview that represent the exact data sent by the backend when fetching /inspections
  • added a GET to @/app/api/inspections/route.ts
  • Use this new route in the dashboard page to populate the inspections list
  • Added click event on InspectionElement that redirects to the label-data-validation page
  • Configured the search in dashboard page

@Youllou Youllou linked an issue Nov 19, 2024 that may be closed by this pull request
11 tasks
@Youllou Youllou force-pushed the 283-as-a-dev-i-want-to-refactor-the-user-page-call-dashboardpage-component branch from e13d892 to efb0931 Compare November 21, 2024 14:54
@Youllou Youllou self-assigned this Nov 21, 2024
@Youllou Youllou force-pushed the 283-as-a-dev-i-want-to-refactor-the-user-page-call-dashboardpage-component branch from da6d206 to 8f6b8c6 Compare December 12, 2024 14:56
@Youllou Youllou force-pushed the 283-as-a-dev-i-want-to-refactor-the-user-page-call-dashboardpage-component branch from 0447a14 to 3af99da Compare December 17, 2024 16:46
@Youllou Youllou marked this pull request as ready for review December 17, 2024 21:30
@Youllou Youllou requested a review from a team as a code owner December 17, 2024 21:30
…ing logic

- Renamed FertilizerList.tsx to InspectionList.tsx
- Popped out InspectionElement.tsx of InspectionList.tsx
- Created test files (test are to do)
- Renamed FertilizerPreview.ts to InspectionPreview.ts
- Modified InspectionPreview.ts to represent the exact data sent by the backend
- added a GET to @/app/api/inspections/route.ts
- Use this new route in InspectionList.tsx
- Added click event on InspectionElement.tsx
- Configured the search in @/app/dashboard/page.tsx
@Youllou Youllou force-pushed the 283-as-a-dev-i-want-to-refactor-the-user-page-call-dashboardpage-component branch from cd9f3f1 to 8c26b3e Compare January 6, 2025 16:49
Moved request to backend logic from InspectionList.tsx to dashboard page
Made some css modification for a full zoom and responsiveness compliance
Started working on Dashboard.test.tsx (Not sure what to test in there)
Copy link
Member

@k-allagbe k-allagbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Few suggestions:

  • remove role and location
  • username instead of email. And display the actual username.
  • force the background colours where necessary to avoid unwanted colour changes in dark mode.
  • add a loading animation when there is a backend fetch
  • let's keep the pages sober by removing component animations (search bar, inspection items etc..)

@SamuelPelletierEvraire
Copy link
Contributor

SamuelPelletierEvraire commented Jan 13, 2025

Looks great.

Few suggestions:

  • remove role and location
  • username instead of email. And display the actual username.
  • force the background colours where necessary to avoid unwanted colour changes in dark mode.
  • add a loading animation when there is a backend fetch
  • let's keep the pages sober by removing component animations (search bar, inspection items etc..)

I would ratter say dont remove (role and location --- username instead of email. ) but hide them for now because we dont actually have those information in the futur if the app is put online those information are gonna be accessible. @k-allagbe what do you thinks about this ?

@k-allagbe
Copy link
Member

I would ratter say dont remove ( remove role and location --- username instead of email. ) but hide them for now

Same thing, really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a dev, I want to refactor the user page call DashboardPage component.
3 participants