-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #283 : Dashboard #333
base: main
Are you sure you want to change the base?
Issue #283 : Dashboard #333
Conversation
e13d892
to
efb0931
Compare
da6d206
to
8f6b8c6
Compare
0447a14
to
3af99da
Compare
…ing logic - Renamed FertilizerList.tsx to InspectionList.tsx - Popped out InspectionElement.tsx of InspectionList.tsx - Created test files (test are to do) - Renamed FertilizerPreview.ts to InspectionPreview.ts - Modified InspectionPreview.ts to represent the exact data sent by the backend - added a GET to @/app/api/inspections/route.ts - Use this new route in InspectionList.tsx - Added click event on InspectionElement.tsx - Configured the search in @/app/dashboard/page.tsx
cd9f3f1
to
8c26b3e
Compare
Moved request to backend logic from InspectionList.tsx to dashboard page Made some css modification for a full zoom and responsiveness compliance Started working on Dashboard.test.tsx (Not sure what to test in there)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
Few suggestions:
- remove role and location
- username instead of email. And display the actual username.
- force the background colours where necessary to avoid unwanted colour changes in dark mode.
- add a loading animation when there is a backend fetch
- let's keep the pages sober by removing component animations (search bar, inspection items etc..)
I would ratter say dont remove (role and location --- username instead of email. ) but hide them for now because we dont actually have those information in the futur if the app is put online those information are gonna be accessible. @k-allagbe what do you thinks about this ? |
Same thing, really. |
Fix : #283
dashboard
pageUserMenu
that redirects to/dashboard
InspectionList
InspectionElement
InspectionPreview
that represent the exact data sent by the backend when fetching/inspections
GET
to@/app/api/inspections/route.ts
dashboard
page to populate the inspections listInspectionElement
that redirects to the label-data-validation pagedashboard
page