Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated notebook #3

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Updated notebook #3

wants to merge 12 commits into from

Conversation

leejaeka
Copy link

@leejaeka leejaeka commented Feb 1, 2024

Updated notebook to have metadata and top k documents returned. Please read the comments in the notebook for more information.

Currently it processes .csv file and only connects to postgresql db server.

Updated notebook to have metadata and top k documents returned
to remove -copy2
@leejaeka leejaeka requested a review from k-allagbe February 1, 2024 18:45
@leejaeka leejaeka self-assigned this Feb 1, 2024
@k-allagbe
Copy link
Member

@leejaeka I've included the notebook you provided and added secret management in PR #2 as you requested. Please take a look and feel free to suggest any changes.

@rngadam
Copy link

rngadam commented Feb 4, 2024

don't forget to set the Projects field

Note that this is all locally stored. Default vector store created using this serialisation creates a .json file of size 3gb.
@rngadam
Copy link

rngadam commented Feb 9, 2024

@leejaeka have a look at the checks to resolve the failing checks (LICENSE and TESTING.md).

@rngadam
Copy link

rngadam commented Feb 13, 2024

@leejaeka fix failing checks before submitting for review:

image

llamaindex-load.ipynb notebook contains Python code to download llamaindex query engine v1 from Azure Storage Container locally. Notebook also shows how to query and retrieve metadata and data for debugging and testing.
@leejaeka
Copy link
Author

TESTING.md is temporay. Will fill them out

@rngadam
Copy link

rngadam commented Feb 14, 2024

@leejaeka looks like @k-allagbe had made changes separately that now conflict with yours.

rebase your branch on the main branch to resolve the conflict.

@rngadam
Copy link

rngadam commented Feb 16, 2024

@leejaeka you've used a merge strategy instead of rebase. we prefer rebase to keep a clean history on the main branch.

see:

https://github.com/ai-cfia/.github/blob/907bc0fab2b1025327ae7dd3687b597fd5649f23/profile/CONTRIBUTING.md

"Handling divergent branches"

Created llamaindex-test.ipynb that returns test accuracy. Llamaindex updated some packages so some changes to importing codes.
CFIAleejaeka and others added 4 commits March 6, 2024 09:45
Openai updated importing codes and packages were not being located correctly
load api key added
@rngadam
Copy link

rngadam commented Mar 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Review
Development

Successfully merging this pull request may close these issues.

4 participants