Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plotting tools for ptype data #40

Merged
merged 6 commits into from
Jun 25, 2024
Merged

plotting tools for ptype data #40

merged 6 commits into from
Jun 25, 2024

Conversation

sophiaanr
Copy link
Collaborator

Python script that has several plotting functions including uncertainty, probability, ptype, winds, dewpt, sp, and temp. Used primarily for generating useful visualization for a single valid time or a time lagged ensemble.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@charlie-becker charlie-becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contributions! The functionality looks great and I really like the visualizations in the notebook and the scripted functions. I made some minor comments regarding functional flexibility and overall organization.

scripts/plotting_tools.py Outdated Show resolved Hide resolved
scripts/plotting_tools.py Outdated Show resolved Hide resolved
scripts/plotting_tools.py Outdated Show resolved Hide resolved
scripts/plotting_tools.py Outdated Show resolved Hide resolved
scripts/plotting_tools.py Outdated Show resolved Hide resolved
@charlie-becker
Copy link
Collaborator

Thank you for making the changes. The only request I have is to move plotting_tools.py to the ptype-physical/ptype/ folder and change the imports accordingly (from ptype.plotting_tools import ...) as this is our typical code structure. Everything else looks good to me.

@charlie-becker
Copy link
Collaborator

Thanks for updating the structure. Looks good to me, merging.

@charlie-becker charlie-becker merged commit 216f522 into main Jun 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants