Extend embedded also to OptimadeQueryFilterWidget #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready to be reviewed+merged since |
Is there anything I should review besides the one-line code change? |
No, that's the change... |
csadorf
reviewed
Nov 5, 2020
csadorf
reviewed
Nov 5, 2020
CasperWA
force-pushed
the
extend_embedded_optimade_widget
branch
from
df3fc4a
to
1f88a66
Compare
csadorf
approved these changes
Nov 5, 2020
unkcpz
pushed a commit
to unkcpz/aiidalab-widgets-base
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
embeddedparameter is now part ofOptimadeQueryFilterWidgetas well, and this change will ensure theOptimadeQueryWidgetextends theembeddedparameter also to this sub-widget.Note, this will not be valid until CasperWA/voila-optimade-client#203 has been merged and a new version of
optimade-clientis released.