-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies: Update requirement aiida-core~=2.1
#299
Conversation
To support AiiDA 2.x, the minimum version of |
0479e08
to
93ab352
Compare
b28e141
to
5cf955f
Compare
5cf955f
to
50a3dee
Compare
Just made a release of
I realise the holidays are around the corner, but it would be great if we can get this sorted early in the new year. A bunch of work is blocked and waiting on ACWF v2.0 |
50a3dee
to
7e2425e
Compare
ac39a2c
to
4d8d95e
Compare
Ok, all dependencies have been updated. I just had to update the implementation for BigDFT because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sphuber, I didn't go through all the files to see the changes. But I tested in a new installation in my laptop and it works well. I run a relaxation and an eos for Si. Both with CP2K and using the CLI. Then I tried the plotting part, all with command line. The only relevant comment I have that aiida keeps trowing a warning:
aiida/engine/processes/workchains/restart.py:61: AiidaDeprecationWarning: Setting a boolean as value for
handler_overrides is deprecated. Use {'handler_name': {'enabled': True} instead. (this will be removed in v3)
If you know how to fix it, good. Otherwise no problem, we can go on anyway.
I know how to fix this, if the offending code comes from this package at least. If it is part of one of the plugin packages, that would have to be updated, but I suspect it comes from here. I will have a look at it later. |
4d8d95e
to
36d163b
Compare
36d163b
to
8ba9791
Compare
Fixes #300