Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: Update requirement aiida-core~=2.1 #299

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

sphuber
Copy link
Collaborator

@sphuber sphuber commented Feb 6, 2023

Fixes #300

@danielhollas
Copy link

To support AiiDA 2.x, the minimum version ofaiida-orca needs to be set to 0.6. Also, the entry point for the main calcjob was renamed from orca_main to orca.orca to make it more in line with other AiiDA plugins. Looks like that will need to be updated in a couple places here. We've also changed some exit codes, not sure if it affects anything here.

@sphuber sphuber force-pushed the fix/support-aiida-2.0 branch 21 times, most recently from 0479e08 to 93ab352 Compare October 5, 2023 09:12
@sphuber sphuber force-pushed the fix/support-aiida-2.0 branch 2 times, most recently from b28e141 to 5cf955f Compare December 11, 2023 14:13
@sphuber sphuber force-pushed the fix/support-aiida-2.0 branch from 5cf955f to 50a3dee Compare December 22, 2023 13:04
@sphuber
Copy link
Collaborator Author

sphuber commented Dec 22, 2023

Just made a release of aiida-wien2k, so now the only two plugins that are blocking:

  • aiida-vasp I have backported the fix that is required and @espenfl will look into making a release aiida-vasp==3.1.0 is now out
  • aiida-bigdft @ljbeal quick reminder that it would be great to have a release of the plugin. Let me know if you'd like help with this, more than happy to help out

I realise the holidays are around the corner, but it would be great if we can get this sorted early in the new year. A bunch of work is blocked and waiting on ACWF v2.0

@sphuber sphuber force-pushed the fix/support-aiida-2.0 branch from 50a3dee to 7e2425e Compare January 4, 2024 14:51
@sphuber sphuber force-pushed the fix/support-aiida-2.0 branch 2 times, most recently from ac39a2c to 4d8d95e Compare February 19, 2024 16:26
@sphuber
Copy link
Collaborator Author

sphuber commented Feb 19, 2024

Ok, all dependencies have been updated. I just had to update the implementation for BigDFT because aiida-bigdft had some major refactoring. Essentialy, the dedicated relax workchain was removed so I replaced it with the BigdftBaseWorkChain. The tests now pass, but I am not sure if the implementation is actually correct. @ljbeal it would be great if you could have a look at the changes.

bosonie
bosonie previously approved these changes Feb 24, 2024
Copy link
Collaborator

@bosonie bosonie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sphuber, I didn't go through all the files to see the changes. But I tested in a new installation in my laptop and it works well. I run a relaxation and an eos for Si. Both with CP2K and using the CLI. Then I tried the plotting part, all with command line. The only relevant comment I have that aiida keeps trowing a warning:
aiida/engine/processes/workchains/restart.py:61: AiidaDeprecationWarning: Setting a boolean as value for handler_overrides is deprecated. Use {'handler_name': {'enabled': True} instead. (this will be removed in v3)
If you know how to fix it, good. Otherwise no problem, we can go on anyway.

@sphuber
Copy link
Collaborator Author

sphuber commented Feb 26, 2024

The only relevant comment I have that aiida keeps trowing a warning:
aiida/engine/processes/workchains/restart.py:61: AiidaDeprecationWarning: Setting a boolean as value for handler_overrides is deprecated. Use {'handler_name': {'enabled': True} instead. (this will be removed in v3)
If you know how to fix it, good. Otherwise no problem, we can go on anyway.

I know how to fix this, if the offending code comes from this package at least. If it is part of one of the plugin packages, that would have to be updated, but I suspect it comes from here. I will have a look at it later.

@sphuber sphuber force-pushed the fix/support-aiida-2.0 branch from 36d163b to 8ba9791 Compare February 26, 2024 11:16
@sphuber sphuber merged commit 090e475 into master Feb 26, 2024
4 checks passed
@sphuber sphuber deleted the fix/support-aiida-2.0 branch February 26, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make a release compatible with aiida-core~=2.0
3 participants