Tests: Add test to guarantee CLI is reachable #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing explicit `click_completion()` which is no longer needed for modern versions of click.
There are tests for the CLI but these use click's `CliRunner` which calls the commands directly from the Python API instead of calling the actual CLI script. This would not catch if the script is not properly installed or reachable. Here a test is added that tries to call the CLI through a subprocess, which simulates the real situation of a user invoking it. This test would have caught the missing imports that were accidentally removed by the `ruff` linter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are tests for the CLI but these use click's
CliRunnerwhich calls the commands directly from the Python API instead of calling the actual CLI script. This would not catch if the script is not properly installed or reachable. Here a test is added that tries to call the CLI through a subprocess, which simulates the real situation of a user invoking it.