Devops: Exclude CP2K protocol YAML from format hook #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The protocol file includes a couple of instances of `ON` and `OFF` that are intended as literal string values. The formatter strips quotes from strings without spaces as it is not required in YAML. However, in YAML, the `ON` and `OFF` values are also aliases for `true` and `false` and so the formatter standardizes these values to `true` and `false`. The file is excluded from the formatter for that reason.
|
@bosonie Thanks for testing. This should fix this problem, but since I cannot test CP2K I cannot be sure it caught everything. It would be great if you could give this another spin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #336
The protocol file includes a couple of instances of
ONandOFFthat are intended as literal string values. The formatter strips quotes from strings without spaces as it is not required in YAML. However, in YAML, theONandOFFvalues are also aliases fortrueandfalseand so the formatter standardizes these values totrueandfalse. The file is excluded from the formatter for that reason.