Drop py38

[eimrek]

fixes #499

[eimrek]

@CasperWA I also added 3.11 to the CI tests. i guess if they pass, I can add that to the list of supported python versions as well. Then the versions match with aiida-core.

[eimrek]

@CasperWA regarding the readme compatilibty matrix, we still keep versions 1.0-1.2 compatible with AiiDA 2.0-3.0, right? It should be the case, as long as you use the don't use python 3.8.

[CasperWA]

Looks good to me - just need to update the AiiDA version range in the README for the new AiiDA-OPTIMADE version range.

Did you run pyupgrade --py39-plus on all the files or where do the other changes come from (related to open() and such)?

[CasperWA]

@CasperWA regarding the readme compatilibty matrix, we still keep versions 1.0-1.2 compatible with AiiDA 2.0-3.0, right? It should be the case, as long as you use the don't use python 3.8.

Hmm. I'd only keep it compatible with the versions of AiiDA that support Python 3.8, I suppose?

[eimrek]

thanks @CasperWA

Did you run pyupgrade --py39-plus on all the files or where do the other changes come from (related to open() and such)?

I ran pyupgrade --py37-plus before (that changed open()) but now also pyupgrade --py39-plus, which introduced many changes to the typing library imports.

Regarding the compatilibity matrix, i updated according to the following:

• aiida >=2.0.0, <2.4.0 is compatible with py3.8, so i used that range for 1.0-1.2
• aiida >=2.2.0 is compatible with py 3.11, so i used that for the new version that will also be compatible with py3.11.

Feel free to suggest alternatives.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (04c7d2d) 92.91% compared to head (6fba496) 92.90%.
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #500      +/-   ##
===========================================
- Coverage    92.91%   92.90%   -0.02%     
===========================================
  Files           33       33              
  Lines         1383     1381       -2     
===========================================
- Hits          1285     1283       -2     
  Misses          98       98              

Flag	Coverage Δ
aiida	89.21% <96.66%> (-0.02%)	⬇️
mongo	79.72% <100.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
aiida_optimade/cli/cmd_init.py	99.20% <100.00%> (ø)
aiida_optimade/entry_collections.py	98.72% <100.00%> (ø)
aiida_optimade/mappers/entries.py	95.83% <100.00%> (ø)
aiida_optimade/mappers/structures.py	89.18% <100.00%> (-0.29%)	⬇️
aiida_optimade/translators/entities.py	86.30% <100.00%> (ø)
aiida_optimade/translators/structures.py	91.17% <100.00%> (ø)
aiida_optimade/translators/utils.py	89.18% <100.00%> (ø)
aiida_optimade/utils.py	100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[CasperWA]

This looks good to me.

After merging this, the currently failing dependabot PRs should be updated and hopefully they will succeed - then they should be merged and v1.2.0 should be released (probably after running CI workflows to check for any new dependency updates).

Note, the dependabot PRs should auto-update, if not, one should wait until the CI workflows running after merging this PR finish and then the PRs should be updated manually.

[eimrek]

thanks @CasperWA the PRs didnt seem to get updated automatically. I merged develop into the aiida update PR #484. Is this what you meant? If that's fine i'll do the same for #482 as well.

[CasperWA]

So I'll just finish up with merging the latest dependency updates, and then I'll release v1.2.0. Please then check everything you need is solved by v1.2.0 concerning the immediate issue(s) and subsequent requirement for dropping Python 3.8 support :)

[eimrek]

thanks @CasperWA! Everything works great!

[CasperWA]

thanks @CasperWA! Everything works great!

Thank you! 😄