Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic implementation of bands.x #1033

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Basic implementation of bands.x #1033

merged 2 commits into from
Jul 10, 2024

Conversation

bastonero
Copy link
Collaborator

An implementation that wraps the binary bands.x was missing. This program is used to find the symmetries of wavefunctions, to re-order the bands, and to perform basic post-processings, such as the calculation of the momentum operator.

The current parser only performs basic parsing, with no specialized outputs for k-point wavefunction symmetries, nor momentum operator, nor bands. This can be, for instance, implemented over time depending on user request.

Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bastonero all looks good. Just some minor requests.

As a side note, not sure if you are already aware of aiida-shell but for it makes it really easy to run these small kind of utilities without having to write dedicated plugins. You can see an example of QE the with use of bands.x in the online docs.

src/aiida_quantumespresso/calculations/bands.py Outdated Show resolved Hide resolved
src/aiida_quantumespresso/calculations/bands.py Outdated Show resolved Hide resolved
tests/parsers/fixtures/bands/default/aiida.out Outdated Show resolved Hide resolved
@bastonero
Copy link
Collaborator Author

Thanks a lot @sphuber for the review.

I was aware of the plugin, but thanks for the reminder, I wasn't aware of the very nice docs. Here I was interested to use the CalcJob/WorkChain for future composite WorkChains. But good to keep in mind about aiida-shell.

@bastonero
Copy link
Collaborator Author

bastonero commented Jun 18, 2024

PS: any idea why the docs is always failing lately?

EDIT: locally it builds w/o any warning

@mbercx
Copy link
Member

mbercx commented Jun 20, 2024

PS: any idea why the docs is always failing lately?

Hmm, let me have a look 👀

@bastonero bastonero added the pr/blocked PR is blocked by another PR that should be merged first label Jun 20, 2024
bastonero and others added 2 commits July 10, 2024 13:15
An implementation that wraps the binary `bands.x` was missing.
This program is used to find the symmetries of wavefunctions,
to re-order the bands, and to perform basic post-processings,
such as the calculation of the momentum operator.

The current parser only performs basic parsing, with no specialized
outputs for k-point wavefunction symmetries, nor momentum operator,
nor bands. This can be, for instance, implemented over time depending
on user request.
@sphuber
Copy link
Contributor

sphuber commented Jul 10, 2024

Fixed the RTD build so merging this. Thanks @bastonero

@sphuber sphuber merged commit 651fd01 into main Jul 10, 2024
13 checks passed
@sphuber sphuber deleted the calculations/bands branch July 10, 2024 11:23
mikibonacci pushed a commit to mikibonacci/aiida-quantumespresso that referenced this pull request Aug 22, 2024
…m#1033)

An implementation that wraps the binary `bands.x` was missing.
This program is used to find the symmetries of wavefunctions,
to re-order the bands, and to perform basic post-processings,
such as the calculation of the momentum operator.

The current parser only performs basic parsing, with no specialized
outputs for k-point wavefunction symmetries, nor momentum operator,
nor bands. This can be, for instance, implemented over time depending
on user request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants