Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customised docker image for running calculation out-of-box #981

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Nov 4, 2023

supersede #980 since push to ghcr.io use GITHUB_TOKEN which has no write permission to package for forked PR.
Based on aiidateam/aiida-core#6170

Start a QE calculation can be quite straightforward as:

docker run --rm -it ghcr.io/aiidateam/aiida-quantumespresso:pr-981 bash
aiida-quantumespresso calculation launch pw -X pw-7.2@localhost -F SSSP/1.3/PBE/efficiency -S 254 -k 1 1 1
  • pre-commit fixes

@unkcpz unkcpz added the pr/blocked PR is blocked by another PR that should be merged first label Nov 4, 2023
@mbercx
Copy link
Member

mbercx commented Nov 12, 2023

Thanks @unkcpz! Just for some context: what is the goal here? To run full integration tests via a docker setup?

@unkcpz
Copy link
Member Author

unkcpz commented Nov 13, 2023

Three goals from my point of view:

  1. As an example to show how to set up a pre-installed computer/code in an image, the use case comes from https://aiida.discourse.group/t/building-docker-image-with-pre-configured-aiida-computer/132
  2. An image for plugin developers that can easily run real calculation without burden of setup, this was mentioned by @bastonero in a slack channel if I remember correctly—pinning @bastonero for comment.
  3. (Not important since there are already the integration tests run real calculations) an advantage I can notice is the image make it a bit easy to reproduce the integration test issue.

.docker/Dockerfile Outdated Show resolved Hide resolved
.docker/tests/conftest.py Outdated Show resolved Hide resolved
.docker/Dockerfile Outdated Show resolved Hide resolved
.docker/Dockerfile Outdated Show resolved Hide resolved
@unkcpz unkcpz removed the pr/blocked PR is blocked by another PR that should be merged first label Nov 15, 2023
@bastonero
Copy link
Collaborator

Hi @unkcpz, indeed I once said it'd be great to have something like this. Re testing. I think it is extremely valuable and it can be used as an alternative to the virtual machine, which I think it has even too much stuff and it is (I guess) much more heavy to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants