kiwipy/rmq related modules into independent module #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #297 +/- ##
======================================
Coverage ? 89.80%
======================================
Files ? 28
Lines ? 3176
Branches ? 0
======================================
Hits ? 2852
Misses ? 324
Partials ? 0 ☔ View full report in Codecov by Sentry. |
unkcpz
force-pushed
the
rmq-out
branch
4 times, most recently
from
156d81a to
fc52fcd
Compare
unkcpz
force-pushed
the
rmq-out
branch
2 times, most recently
from
3b8104b to
5af4710
Compare
unkcpz
force-pushed
the
rmq-out
branch
3 times, most recently
from
947fa3b to
aebec4f
Compare
unkcpz
changed the title
unkcpz
force-pushed
the
rmq-out
branch
7 times, most recently
from
85fc72a to
da644ac
Compare
unkcpz
commented
Dec 17, 2024
Comment on lines
+22
to
+38
| class MockCoordinator: | ||
| def __init__(self): | ||
| self._task_subscribers = {} | ||
| self._broadcast_subscribers = {} | ||
| self._rpc_subscribers = {} | ||
| self._closed = False | ||
|
|
||
| def is_closed(self) -> bool: | ||
| return self._closed | ||
|
|
||
| def close(self): | ||
| if self._closed: | ||
| return | ||
| self._closed = True | ||
| del self._task_subscribers | ||
| del self._broadcast_subscribers | ||
| del self._rpc_subscribers |
There was a problem hiding this comment.
This is the Mocked in memory coordinator that in principle can work with sqlite in presto and make it able to submit the calculations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactoring is targeting to decouple the dependencies of using kiwipy+rmq as the communicator for the process control.
By forming a
Coordinatorprotocol contract, the different type of rmq/kiwipy related codes are removed out from plumpy logic. The new contract also pave the way to make it clearly show how a new type coordinator can be implemented (future examples will be thetatzelwurma task broker that has scheduler support and file based task broker require no background service).For the prototype of how a coordinator should look like, the
MockCoordinatorintests/utilsis the coordinator that store things in memory, and can serve as the lightweight ephemeral daemon without persistent functionality.Another major change here is hand write the resolver of future by mimic how tho asyncio does for wrapping
concurrent.futures.Futureintoasyncio.Future. I use the same way to convertasyncio.Futureintoconcurent.futures.Future(which is thekiwipy.Futureas alias).aio_pikaimport lazily by moving the rmq exceptions tormqmodule, this can increase the performance ofimport aiida; aiida.orm.CancellableActionusing composite to behave as a Future like object.asyncio.Futurein favor of aliasplumpy.Futureandconcurrent.futures.Futureinstead of aliaskiwipy.Future._chainand_copy_futuresince we can not just rely on the API of asyncio that is not exposed.coordinator/Communicatorprotocol.coordinator/Coordinatorprotocol and wrap rmq/communicator as a coordinator that not require changs in kiwipy.