Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# Conventions #6

Open
hexagon06 opened this issue May 17, 2017 · 3 comments
Open

C# Conventions #6

hexagon06 opened this issue May 17, 2017 · 3 comments

Comments

@hexagon06
Copy link

While working through the book's Exercises and using the repository as a reference I noticed that the code does not use the standard conventions for C# I'm used to:

  • PascalCasing for all public identifiers except parameters (as described here)
  • Interface names should begin with I
  • Comments for documentation and Intellisense (as described here)

I'll be fixing those as I read through the book on my own fork to help me navigate through the code with more ease. Note that I will not change the implementation except for when something fails to build.

I created this issue here to see if you would be interested in the changes (through pull requests)

p.s. I saw some other issues with regard to compilation as well. I'll be fixing those too, but on a separate branch on the same fork

@ShobhitLamba
Copy link
Collaborator

Hello hexagon06.

Thank you for your interest in aima-csharp. Yes you can go ahead and make pull requests for the changes you wanna implement. I'll merge them once they check out.

@Speedie007
Copy link

Good Day Hexagon06

I have already completed most of what you have discussed here and the points that you have raised including add and fixing the implementation of a ordered sorted Queue required for the search Algorithms which was missing component to implement the missing Informed Search algorithms. My intention was to complete the entire package and complete the remain two or three algorithms and then bring them forward for review to be added to the project. I also have an implementation of the Vacuum cleaner and the Eight Puzzle using the A*Star, Uniform-Cost-Search, Hill Climbing, and Simulated Annealing Algorithms Completed.

@Speedie007
Copy link

If you would like to discuss the work i have completed so far i can be contacted Brendanw@mweb.co.za

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants