-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to app not working in Chrome browser in iOS #128
Comments
Reproduced. iTunes link malfunctions as well though. This is indeed a very unfortunate behaviour by the corporate browser. No such failure is there in Safari or Firefox. Thanks for reporting! |
Is there a reason to open in a new window (target="_blank") for any device? There might be I just can't think of one at the moment. |
Good question @mreinhart. The reasoning is legacy support which, depending on a particular Android setup, would see people navigating directly to Play Store page instead of a new tab. Let's pick this change up for version 2 ("breaking" version). |
@ain Still have this problem with Chrome (on Safari works good), even with |
Thanks for the heads up @AleksandrLeontev, this is something that is in the works. There're also other features that would be launched in v2, making it a major (breaking) release. We have some clean-up to perform and some tests to adjust accordingly. That'll take a bit of time. We're targeting 1st half of January for the v2. |
@ain, |
@ain, Anyone found a fix or workaround for this until v2 is out? |
Sorry for the delay guys! This has been picked up again, please hold on for the update. |
Fix #128 Link to app not working in Chrome browser in iOS
Hi @ain , thanks for the great project! I wanted to make sure I understood the issue here correctly. Does smartbanner.js not work if a user is using an iOS device and a chrome browser? |
Steps to reproduce:
What happens: current page just reloaded. Looks like target="_blank" with this url in Chrome prevents iOS to catch link. Btw, link starting with https://itunes.apple.com.. works fine.
What should happen: You can add check: if iOS && Chrome && link starts with https://apps.apple.com... => delete attribute target="_blank"
The text was updated successfully, but these errors were encountered: