Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not Working on latest Chrome on Ios but working on safari #136

Closed
alinoudev opened this issue Nov 13, 2019 · 2 comments
Closed

Not Working on latest Chrome on Ios but working on safari #136

alinoudev opened this issue Nov 13, 2019 · 2 comments

Comments

@alinoudev
Copy link

Steps to reproduce:

Go to chrome om Ios and try it. Working for safari

What happens:
it just opens the same page in another browser rather than opening the app store
__What should happen__n
it should go to app store

@alinoudev
Copy link
Author

For time being i fixed it by removing _blank from here line 408
return "<div class=\"smartbanner smartbanner--".concat(modifier, " js_smartbanner\">\n <a href=\"javascript:void();\" class=\"smartbanner__exit js_smartbanner__exit\" aria-label=\"").concat(this.closeLabel, "\"></a>\n <div class=\"smartbanner__icon\" style=\"background-image: url(").concat(this.icon, ");\"></div>\n <div class=\"smartbanner__info\">\n <div>\n <div class=\"smartbanner__info__title\">").concat(this.options.title, "</div>\n <div class=\"smartbanner__info__author\">").concat(this.options.author, "</div>\n <div class=\"smartbanner__info__price\">").concat(this.options.price).concat(this.priceSuffix, "</div>\n </div>\n </div>\n <a href=\"").concat(this.buttonUrl, "\" class=\"smartbanner__button\" rel=\"noopener\" aria-label=\"").concat(this.options.button, "\"><span class=\"smartbanner__button__label\">").concat(this.options.button, "</span></a>\n </div>");

@ain ain added the duplicate label Nov 13, 2019
@ain
Copy link
Owner

ain commented Nov 13, 2019

Dupe of #128.

@ain ain closed this as completed Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants