Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change request metadata error to warning #1009

Merged
merged 2 commits into from
May 23, 2024

Conversation

oferda4
Copy link
Contributor

@oferda4 oferda4 commented May 20, 2024

Changes

Make log of "Unable to request metadata from node" warning instead of error as it's handled. This is the same as in line 246 in the same file.
This change will allow to better monitor errors from this lib and distinguish them from warnings.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.04%. Comparing base (c10fed0) to head (7841796).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1009   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files         114      114           
  Lines       16906    16906           
  Branches     2759     2759           
=======================================
  Hits        16068    16068           
  Misses        493      493           
  Partials      345      345           
Flag Coverage Δ
cext 91.94% <100.00%> (-0.02%) ⬇️
integration 94.69% <100.00%> (ø)
purepy 94.49% <100.00%> (ø)
unit 52.72% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ods ods merged commit 14aa358 into aio-libs:master May 23, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants