Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check writer is closing in AIOKafkaConnection.send #1044

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dimastbk
Copy link
Contributor

Changes

Fixes #1038

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

tests/test_conn.py Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.02%. Comparing base (01c60cd) to head (b6fec2d).

Files Patch % Lines
tests/test_conn.py 94.11% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1044   +/-   ##
=======================================
  Coverage   95.02%   95.02%           
=======================================
  Files         114      114           
  Lines       16971    17019   +48     
  Branches     2771     2782   +11     
=======================================
+ Hits        16126    16173   +47     
  Misses        497      497           
- Partials      348      349    +1     
Flag Coverage Δ
cext 91.94% <94.44%> (+0.01%) ⬆️
integration 94.67% <94.44%> (-0.01%) ⬇️
purepy 94.49% <94.44%> (-0.01%) ⬇️
unit 53.29% <83.33%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/test_conn.py Fixed Show fixed Hide fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closing of connection from server don't caught for uvloop
1 participant