Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated BrokerMetadata#nodeId type from int to int | str. #1051

Merged
merged 5 commits into from
Nov 16, 2024
Merged

Updated BrokerMetadata#nodeId type from int to int | str. #1051

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e9697cc
Updated BrokerMetadata#nodeId type from int to (int | str).
jackgene Oct 7, 2024
867069f
FIXME.
jackgene Nov 3, 2024
5cbe7ab
Unused import.
jackgene Nov 3, 2024
5797fb8
Include issue link in FIXME.
jackgene Nov 3, 2024
db572e3
Fix linter errors
ods Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion aiokafka/structs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from __future__ import annotations
ods marked this conversation as resolved.
Show resolved Hide resolved
from collections.abc import Sequence
from dataclasses import dataclass
from typing import Generic, NamedTuple, Optional, TypeVar
Expand Down Expand Up @@ -27,7 +28,7 @@ class TopicPartition(NamedTuple):
class BrokerMetadata(NamedTuple):
"""A Kafka broker metadata used by admin tools"""

nodeId: int
nodeId: int | str # FIXME consider updating implementation (https://github.com/aio-libs/aiokafka/issues/1050)
ods marked this conversation as resolved.
Show resolved Hide resolved
"The Kafka broker id"

host: str
Expand Down
Loading