Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ClusterMetadata request_update() #1056

Merged
merged 11 commits into from
Oct 21, 2024

Conversation

jackgene
Copy link
Contributor

@jackgene jackgene commented Oct 12, 2024

Changes

Fixes #1055

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.08%. Comparing base (01c60cd) to head (3fe7787).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1056      +/-   ##
==========================================
+ Coverage   95.02%   95.08%   +0.06%     
==========================================
  Files         114      114              
  Lines       16971    16982      +11     
  Branches     2771     1763    -1008     
==========================================
+ Hits        16126    16147      +21     
+ Misses        497      487      -10     
  Partials      348      348              
Flag Coverage Δ
cext 92.04% <100.00%> (+0.11%) ⬆️
integration 94.77% <100.00%> (+0.09%) ⬆️
purepy 94.59% <100.00%> (+0.09%) ⬆️
unit 52.99% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ods ods merged commit 608ab24 into aio-libs:master Oct 21, 2024
31 checks passed
@jackgene jackgene deleted the bugfix/cluster_metadata_request_update branch November 4, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClusterMetadata, update_metadata(...) always fails when following request_update() call
2 participants