More types #881
Closed
More types #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace all mypy options with single strict = True which feels like a most reasonable level of typechecking to have (https://mypy.readthedocs.io/en/stable/existing_code.html#introduce-stricter-options) to make a baseplate for further typisation of the library. Also rather than exclude kafka-python modules from mypy checks, add basic type stubs (generated with stubgen) for kafka-python's errors and structs modules.
gnsiva
reviewed
Sep 18, 2023
Comment on lines
+15
to
+20
| cafile: str = None, | ||
| capath: str = None, | ||
| cadata: str = None, | ||
| certfile: str = None, | ||
| keyfile: str = None, | ||
| password: str = None, |
There was a problem hiding this comment.
The typing of these should look like cafile: Optional[str] = None
gnsiva
reviewed
Sep 18, 2023
|
|
||
| [mypy-aiokafka.util] | ||
| ignore_missing_imports = False | ||
| python_version = 3.7 |
There was a problem hiding this comment.
python 3.7 has already been deprecated in the latest version
gnsiva
reviewed
Sep 18, 2023
Comment on lines
+18
to
+19
| replicas: list[int] | ||
| isr: list[int] |
There was a problem hiding this comment.
This form of typing is not available in Python 3.8 which is still supported.
It should be:
from typing import List, NamedTuple
...
replicas: List[int]
isr: List[int]
gnsiva
reviewed
Sep 18, 2023
Comment on lines
+86
to
+88
| # class FailedPayloadsError(KafkaError): | ||
| # payload: Incomplete | ||
| # def __init__(self, payload, *args) -> None: ... |
There was a problem hiding this comment.
cant this just be deleted if it is commented out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds typings for
helpersanderrorsmodulesChecklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.