912.bugfix allow checksum to be None on ConsumerRecord
#912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using serialization frameworks like pydantic, I can not attach a consumer record because checksum can be None. Since it is marked as deprecated, it seems reasonable to mark it as optional here.
zschumacher
changed the title
None on ConsumerRecord
Not really sure what this means - do I need to create a CHANGES folder? |
Codecov Report
@@ Coverage Diff @@
## master #912 +/- ##
=======================================
Coverage 97.56% 97.56%
=======================================
Files 30 30
Lines 5451 5451
=======================================
Hits 5318 5318
Misses 133 133
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When using serialization frameworks like pydantic, I can not attach a consumer record because checksum can be None. Since it is marked as deprecated, it seems reasonable to mark it as optional here.
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.