Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ruff for linting and formatting #964

Merged
merged 8 commits into from
Jan 21, 2024
Merged

Use ruff for linting and formatting #964

merged 8 commits into from
Jan 21, 2024

Conversation

ods
Copy link
Collaborator

@ods ods commented Jan 21, 2024

Changes

  • flake8 and isort are replaced with ruff check
  • black is replaced with ruff format
  • Formatting is applied to all the code

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (2cbeee6) 95.07% compared to head (04aa839) 95.07%.

Files Patch % Lines
aiokafka/conn.py 77.94% 9 Missing and 6 partials ⚠️
tests/_testutil.py 79.41% 5 Missing and 2 partials ⚠️
aiokafka/consumer/consumer.py 90.69% 4 Missing ⚠️
aiokafka/cluster.py 66.66% 3 Missing ⚠️
aiokafka/producer/producer.py 91.66% 2 Missing and 1 partial ⚠️
tests/conftest.py 93.87% 2 Missing and 1 partial ⚠️
tests/test_coordinator.py 98.00% 2 Missing ⚠️
aiokafka/admin/client.py 93.33% 0 Missing and 1 partial ⚠️
aiokafka/client.py 96.96% 1 Missing ⚠️
aiokafka/consumer/fetcher.py 97.22% 1 Missing ⚠️
... and 6 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #964   +/-   ##
=======================================
  Coverage   95.07%   95.07%           
=======================================
  Files         106      106           
  Lines       16323    16332    +9     
  Branches     2610     2610           
=======================================
+ Hits        15519    15528    +9     
  Misses        530      530           
  Partials      274      274           
Flag Coverage Δ
cext 91.77% <91.26%> (+<0.01%) ⬆️
integration 94.72% <95.50%> (+<0.01%) ⬆️
purepy 94.53% <95.15%> (-0.05%) ⬇️
unit 44.88% <29.49%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ods ods merged commit 935ce1c into aio-libs:master Jan 21, 2024
31 of 33 checks passed
@ods ods deleted the ruff branch January 21, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant