Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI jobs to run on Apple Silicon macOS 14 runner #19

Merged
merged 4 commits into from
Feb 26, 2024
Merged

Update CI jobs to run on Apple Silicon macOS 14 runner #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8188615
Update CI to use macOS 14 Apple Silicon runner
calda Jan 31, 2024
8f67d98
Continue using macOS 13 on jobs that use Xcode 14.2
calda Jan 31, 2024
4277589
Remove -downloadPlatform visionOS since macOS 14 runner already inclu…
calda Feb 21, 2024
72283c9
Dont run visionOS tests since they time out
calda Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ jobs:
with:
xcode: ${{ matrix.xcode }}
- name: Build Package
run: SKIP_VISION_OS=true bundle exec rake test:package:all
run: SKIP_VISION_OS=true bundle exec rake test:package:github_actions

test-package-macos-13:
name: "Test Package"
runs-on: macos-13
runs-on: macos-14
strategy:
fail-fast: false
matrix:
Expand All @@ -40,7 +40,7 @@ jobs:
with:
xcode: ${{ matrix.xcode }}
- name: Build Package
run: bundle exec rake test:package:all
run: bundle exec rake test:package:github_actions

build-example-excluding-visionOS:
name: "Build Example App"
Expand All @@ -63,7 +63,7 @@ jobs:

build-example-macos-13:
name: "Build Example App"
runs-on: macos-13
runs-on: macos-14
strategy:
fail-fast: false
matrix:
Expand Down
14 changes: 4 additions & 10 deletions Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ namespace :test do
desc 'Tests the Lottie package for all supported platforms'
task all: ['iOS', 'macOS', 'tvOS', 'visionOS']

# The visionOS tests time out in GitHub actions as of Feb 2024, so we exclude them for now.
desc 'Tests the Lottie package for all platforms supported by GitHub Actions'
task github_actions: ['iOS', 'macOS', 'tvOS']

desc 'Tests the Lottie package for iOS'
task :iOS do
xcodebuild('test -scheme Lottie -destination "platform=iOS Simulator,name=iPhone SE (3rd generation)"')
Expand Down Expand Up @@ -97,16 +101,6 @@ def ifVisionOSEnabled
if ENV["SKIP_VISION_OS"] == "true"
puts "Skipping visionOS build"
else
installVisionOSIfNecessary()
yield
end
end

def installVisionOSIfNecessary
# visionOS is unsupported by default on Intel, but we can override this
# https://github.com/actions/runner-images/issues/8144#issuecomment-1902072070
sh 'defaults write com.apple.dt.Xcode AllowUnsupportedVisionOSHost -bool YES'
sh 'defaults write com.apple.CoreSimulator AllowUnsupportedVisionOSHost -bool YES'

xcodebuild("-downloadPlatform visionOS")
end
Loading