Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled Rheostat component is displayed with cursor: pointer #212

Open
nikolas opened this issue Feb 15, 2019 · 1 comment · May be fixed by #287
Open

Disabled Rheostat component is displayed with cursor: pointer #212

nikolas opened this issue Feb 15, 2019 · 1 comment · May be fixed by #287
Labels
help wanted

Comments

@nikolas
Copy link

nikolas commented Feb 15, 2019 •
edited
Loading

Hi,
I have a <Rheostat> component with disabled={true}, and it's getting displayed with a pointer cursor, making it appear to the user that this slider isn't disabled.

2019-02-15-133416_991x469_scrot

2019-02-15-133425_1012x509_scrot

Basically these sliders shouldn't be focusable either when they're disabled.
richardgreg added a commit to richardgreg/rheostat that referenced this issue Nov 2, 2021
@richardgreg
Disable pointer cursor for a disabled Rheostat
f1567a8 
Fixes airbnb#212

Signed-off-by: Richard Gregory <richardgrecoson@gmail.com>
@richardgreg richardgreg linked a pull request Nov 2, 2021 that will close this issue
Open
@rastersysteme
Copy link

Sadly changing the cursor is not enough because the button is still focusable. On top of it, the tabindex must be set to -1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable pointer cursor for a disabled Rheostat richardgreg/rheostat
3 participants
@ljharb @nikolas @rastersysteme