Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[slider] Add aria-label to Slider #286

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[slider] Add aria-label to Slider #286

wants to merge 1 commit into from

Conversation

richardgreg
Copy link

Fixes #273

Signed-off-by: Richard Gregory richardgrecoson@gmail.com

@richardgreg
[slider] Add aria-label to Slider
8ff60ce 
Fixes airbnb#273

Signed-off-by: Richard Gregory <richardgrecoson@gmail.com>
ljharb
ljharb requested changes Mar 31, 2022
View reviewed changes
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - this needs tests before it could be added, and should be added to docs as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
semver-minor: new stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Aria-labels can't be added to slider buttons
2 participants
@richardgreg @ljharb