-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send environment variables #52
Labels
Comments
In theory we should implement filters and then users will be able to pass those via them. |
Filters: #48 |
@kyrylo My understanding is that filters act to remove sensitive data, where this could possibly add sensitive data to the context? I'm not sure how we would be sending data via filters? |
I guess you meant #67. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We don't seem to pass any environment variables along with the payload. It should get passed into the
Airbrake.log()
func, but I don't see that happening. We set the environment (as in prod/staging/etc), inside the payload's context field, but not the top-level "environment" field, which is for env vars.We can get this via
os.environ
and set it automatically. I think there should be a field enabling this, but defaulting to be disabled. The env could hold sensitive stuff and we don't want to send that by default.The text was updated successfully, but these errors were encountered: