Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send environment variables #52

Open
zachgoldstein opened this issue Feb 22, 2017 · 5 comments
Open

Send environment variables #52

zachgoldstein opened this issue Feb 22, 2017 · 5 comments

Comments

@zachgoldstein
Copy link
Contributor

We don't seem to pass any environment variables along with the payload. It should get passed into the Airbrake.log() func, but I don't see that happening. We set the environment (as in prod/staging/etc), inside the payload's context field, but not the top-level "environment" field, which is for env vars.

We can get this via os.environ and set it automatically. I think there should be a field enabling this, but defaulting to be disabled. The env could hold sensitive stuff and we don't want to send that by default.

@kyrylo
Copy link
Contributor

kyrylo commented Feb 23, 2017

In theory we should implement filters and then users will be able to pass those via them.

@zachgoldstein
Copy link
Contributor Author

Filters: #48

@zachgoldstein
Copy link
Contributor Author

@kyrylo My understanding is that filters act to remove sensitive data, where this could possibly add sensitive data to the context? I'm not sure how we would be sending data via filters?

@zachgoldstein
Copy link
Contributor Author

@kyrylo #52 contains tests that make sure that blacklisted keys do not get sent in the environment payload.

@kyrylo
Copy link
Contributor

kyrylo commented Mar 9, 2017

I guess you meant #67. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants