Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement name and description discovery over nats and fastapi #353

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

kumaranvpl
Copy link
Collaborator

Description

Fixes #338, #339

Type of change

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • I have included code examples to illustrate the modifications

@kumaranvpl kumaranvpl marked this pull request as draft October 9, 2024 08:27
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 22.72727% with 34 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
fastagency/adapters/nats/base.py 22.58% 24 Missing ⚠️
fastagency/adapters/fastapi/base.py 23.07% 10 Missing ⚠️
Files with missing lines Coverage Δ
fastagency/adapters/fastapi/base.py 19.58% <23.07%> (+1.80%) ⬆️
fastagency/adapters/nats/base.py 21.14% <22.58%> (+0.59%) ⬆️

@kumaranvpl kumaranvpl marked this pull request as ready for review October 9, 2024 09:48
@kumaranvpl kumaranvpl linked an issue Oct 9, 2024 that may be closed by this pull request
@davorrunje davorrunje changed the base branch from main to refactor-workflow-run October 9, 2024 14:36
@davorrunje davorrunje changed the base branch from refactor-workflow-run to main October 9, 2024 14:36
@davorrunje davorrunje added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit 23c1a47 Oct 9, 2024
20 of 21 checks passed
@davorrunje davorrunje deleted the add-discovery branch October 9, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants