Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subscriber close issue #358

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Fix subscriber close issue #358

merged 1 commit into from
Oct 10, 2024

Conversation

kumaranvpl
Copy link
Collaborator

Description

Fixes #354

Type of change

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • I have included code examples to illustrate the modifications

@davorrunje davorrunje added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 0d8a0d1 Oct 10, 2024
21 of 22 checks passed
@davorrunje davorrunje deleted the fix-subscriber-close branch October 10, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davorrunje davorrunje davorrunje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix syncify issue which occurs while trying to close subscriber after chat is over
2 participants
@kumaranvpl @davorrunje