Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (#1748): add Kafka publish no_confirm option #1749

Merged
merged 13 commits into from
Sep 6, 2024
Merged

fix (#1748): add Kafka publish no_confirm option #1749

merged 13 commits into from
Sep 6, 2024

Conversation

Lancetnik
Copy link
Member

Description

Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.

Fixes #1748

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

@Lancetnik Lancetnik added bug Something isn't working AioKafka Issues related to `faststream.kafka` module labels Sep 1, 2024
@Lancetnik Lancetnik self-assigned this Sep 1, 2024
@Lancetnik Lancetnik marked this pull request as draft September 1, 2024 19:46
@Lancetnik Lancetnik marked this pull request as ready for review September 2, 2024 18:40
@@ -102,9 +114,21 @@ def __init__(

self.producer = Producer(self.config, logger=self.logger)

self.__running = True
self._poll_thread = Thread(target=self._poll_loop)
Copy link
Member Author

@Lancetnik Lancetnik Sep 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lancetnik Lancetnik changed the title fix (#1748): add Kafka publish no_wait option fix (#1748): add Kafka publish no_confirm option Sep 2, 2024
@Lancetnik Lancetnik requested a review from kumaranvpl September 2, 2024 18:44
@Lancetnik Lancetnik added the Confluent Issues related to `faststream.confluent` module label Sep 2, 2024
@Lancetnik
Copy link
Member Author

Seems like no-confirm works incorrect in Conluent

@Lancetnik Lancetnik requested review from kumaranvpl, davorrunje and sternakt and removed request for kumaranvpl September 6, 2024 15:20
@kumaranvpl kumaranvpl added this pull request to the merge queue Sep 6, 2024
Merged via the queue into main with commit 54223e1 Sep 6, 2024
31 checks passed
@kumaranvpl kumaranvpl deleted the fix/1748 branch September 6, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AioKafka Issues related to `faststream.kafka` module bug Something isn't working Confluent Issues related to `faststream.confluent` module
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bug: await broker.publish do not waits actual message sends on Kafka(aiokafka)
2 participants