-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (#1748): add Kafka publish no_confirm option #1749
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lancetnik
added
bug
Something isn't working
AioKafka
Issues related to `faststream.kafka` module
labels
Sep 1, 2024
Lancetnik
commented
Sep 2, 2024
faststream/confluent/client.py
Outdated
@@ -102,9 +114,21 @@ def __init__( | |||
|
|||
self.producer = Producer(self.config, logger=self.logger) | |||
|
|||
self.__running = True | |||
self._poll_thread = Thread(target=self._poll_loop) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy from this example: https://github.com/confluentinc/confluent-kafka-python/blob/master/examples/asyncio_example.py
Lancetnik
changed the title
fix (#1748): add Kafka publish no_wait option
fix (#1748): add Kafka publish no_confirm option
Sep 2, 2024
Seems like no-confirm works incorrect in Conluent |
Lancetnik
requested review from
kumaranvpl,
davorrunje and
sternakt
and removed request for
kumaranvpl
September 6, 2024 15:20
kumaranvpl
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.
Fixes #1748
Type of change
Please delete options that are not relevant.
Checklist
scripts/lint.sh
shows no errors)scripts/test-cov.sh
scripts/static-analysis.sh