Add more warning's to nats subscription factory #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HHongSeungWoo can you review this PR, please? |
Comment on lines
359
to
370
| warnings.warn( | ||
| "`idle_heartbeat` option can be used with JetStream (Pull/Push) - only.", | ||
| RuntimeWarning, | ||
| stacklevel=4, | ||
| ) | ||
|
|
||
| if flow_control is not None: | ||
| warnings.warn( | ||
| "`flow_control` option can be used with JetStream (Pull/Push) - only.", | ||
| RuntimeWarning, | ||
| stacklevel=4, | ||
| ) |
There was a problem hiding this comment.
My understanding is that these options only apply to push based consumers.
|
@kumaranvpl can you proofread and polish warnings text, please? |
kumaranvpl
approved these changes
Nov 10, 2024
kumaranvpl
requested changes
Nov 10, 2024
kumaranvpl
previously approved these changes
Nov 11, 2024
kumaranvpl
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.
Fixes #1899
Type of change
Please delete options that are not relevant.
Checklist
scripts/lint.shshows no errors)scripts/test-cov.shscripts/static-analysis.sh