add BYOC tags list/update/replace commands [MILK-337] #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allaouiamine
previously requested changes
Oct 30, 2024
Prime541
force-pushed
the
guillaume.giffard-MILK-337-avn-byoc-tags
branch
from
afeb11e
to
18913b6
Compare
Prime541
force-pushed
the
guillaume.giffard-MILK-337-avn-byoc-tags
branch
from
18913b6
to
e6f246d
Compare
Prime541
force-pushed
the
guillaume.giffard-MILK-337-avn-byoc-tags
branch
from
e6f246d
to
c646e54
Compare
…10 and older - ease debugging
Prime541
force-pushed
the
guillaume.giffard-MILK-337-avn-byoc-tags
branch
from
c646e54
to
094c0c6
Compare
Prime541
commented
Oct 30, 2024
| json_data: dict[str, Any] | None = None, | ||
| headers: dict[str, str] | None = None, | ||
| content: bytes | None = None, | ||
| ): | ||
| self.status_code = status_code | ||
| self.status_code = status_code.value if isinstance(status_code, HTTPStatus) else status_code |
There was a problem hiding this comment.
Fixing str(HTTPStatus.OK) == "HTTPStatus.OK" instead of "200" on python3.10 and older
Prime541
commented
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the missing
avn byoc tags updatecommand that is shown in Aiven's public documentation, but not in Aiven CLI reference.It reuses the same syntax as
service tagscommands.I have tested it in a locally deployed BYOC.
MILK-337