Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy BurnWrappedAjna #123

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Deploy BurnWrappedAjna #123

merged 1 commit into from
Aug 2, 2023

Conversation

EdNoepel
Copy link
Contributor

@EdNoepel EdNoepel commented Aug 1, 2023

Description of change

High level

Implement forge script for deploying BurnWrappedAjna contract. Could not do this with forge create because build process did not like different compiler versions. Not happy about needing to manually edit source of BurnWrapper.sol such that it validates against the correct token address.

No changes to src/.

See alternate implementation PR#124 for an implementation which edits src/ to remove the token address validation.

Copy link
Collaborator

@MikeHathaway MikeHathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EdNoepel EdNoepel changed the title deploy BurnWrapper Deploy BurnWrappedAjna Aug 1, 2023
@EdNoepel EdNoepel merged commit dea251c into develop Aug 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants