Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy BurnWrappedAjna without address validation #124

Closed
wants to merge 2 commits into from

Conversation

EdNoepel
Copy link
Contributor

@EdNoepel EdNoepel commented Aug 1, 2023

Description of change

High level

Alternative implementation of PR#123 which eliminates the address validation, allowing it to be deployed to Goerli and local testchains without code changes.

Description of bug or vulnerability and solution

This change does not target a vulnerability.

Contract size

Pre Change

Contract Size (kB) Margin (kB)
BurnWrappedAjna 5.277 19.299

Post Change

Contract Size (kB) Margin (kB)
BurnWrappedAjna 5.277 19.299

Gas usage

There was a small reduction in deployment cost.

Pre Change

BurnWrappedAjna contract
Deployment Cost Deployment Size
1400933 7662
Function Name min avg median max # calls
balanceOf 561 1227 561 2561 6
decimals 222 222 222 222 1
depositFor 59633 61233 61233 62833 2
name 3246 3246 3246 3246 1
symbol 3267 3267 3267 3267 1
totalSupply 349 1349 1349 2349 2
withdrawTo 440 440 440 440 1

Post Change

BurnWrappedAjna contract
Deployment Cost Deployment Size
1400893 7605
Function Name min avg median max # calls
balanceOf 561 1227 561 2561 6
decimals 222 222 222 222 1
depositFor 59633 61233 61233 62833 2
name 3246 3246 3246 3246 1
symbol 3267 3267 3267 3267 1
totalSupply 349 1349 1349 2349 2
withdrawTo 440 440 440 440 1

@EdNoepel EdNoepel changed the base branch from main to develop August 1, 2023 20:53
@EdNoepel EdNoepel changed the title Deploy AjnaBurnWrapper without address validation Deploy BurnWrappedAjna without address validation Aug 1, 2023
@EdNoepel
Copy link
Contributor Author

EdNoepel commented Aug 2, 2023

Closing without merging due to risk of losing insurance.

@EdNoepel EdNoepel closed this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant