Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test improvements: Add test for cycling voting delegation #128

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Test improvements: Add test for cycling voting delegation #128

merged 1 commit into from
Aug 16, 2023

Conversation

prateek105
Copy link
Contributor

Description of change

High level

  • Add unit test for cycling voting delegation where A delegates to B, B delegates to C, and C delegates again to A, to ensure votes are appropriate for each actor

MikeHathaway
MikeHathaway approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@MikeHathaway MikeHathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the test

EdNoepel
EdNoepel approved these changes Aug 12, 2023
View reviewed changes
Copy link
Contributor

@EdNoepel EdNoepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much thanks.

@MikeHathaway MikeHathaway merged commit 42bb2ca into develop Aug 16, 2023
3 checks passed
@MikeHathaway MikeHathaway deleted the test-cycling-voting-delegation branch August 16, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeHathaway MikeHathaway MikeHathaway approved these changes

@EdNoepel EdNoepel EdNoepel approved these changes

@ith-harvey ith-harvey Awaiting requested review from ith-harvey

@mattcushman mattcushman Awaiting requested review from mattcushman

@grandizzy grandizzy Awaiting requested review from grandizzy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prateek105 @MikeHathaway @EdNoepel