fix #2427 compileAsync a schema with discriminator and $ref #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the discriminator code generation throw MissingRefError when the $ref does not synchronously resolve so that compileAsync can loadSchema and retry.
|
I've made some small changes just to get it passing linting and see how the tests run. |
|
Not sure why coveralls is erroring. Will try a clean branch and see if I get the same issue. |
|
This has been moved to #2433 due to coveralls issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the discriminator code generation throw MissingRefError when the $ref does not synchronously resolve so that compileAsync can loadSchema and retry.
What issue does this pull request resolve?
#2427
What changes did you make?
Make the discriminator code generation throw MissingRefError when the $ref does not synchronously resolve so that compileAsync can loadSchema and retry.
Is there anything that requires more attention while reviewing?
The existing tests create separate test
Ajvinstances by callingwithStandalone(getAjvInstances(AjvClass, …))(https://github.com/ajv-validator/ajv/blob/v8.13.0/spec/discriminator.spec.ts#L22). I could not directly reuse thoseAjvinstances because I need to add theloadSchemaoption and I can’t call compileAsync on anAjvafterwithStandalone. For now I only callednew _Ajv. To what extent should I try creating separate ajv, ajv2019, standalone instances in the test?