Skip to content

Commit

Permalink
test[es]: Force batch size 1 in test (jaegertracing#4865)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
- Resolves jaegertracing#4743

The test is still failing:
https://github.com/jaegertracing/jaeger/actions/runs/6577136964/job/17868105418#step:7:461

From the logs we can see that the new client is started to be used (HEAD
requests with new password), but then a bulk request with password1
comes in and breaks the test.

## Description of the changes
- Set BulkSize to -1, which according to the driver docs disables bulk
processing.

## How was this change tested?
- Local test is successful, but the issue is difficult to reproduce

---------

Signed-off-by: Yuri Shkuro <github@ysh.us>
  • Loading branch information
yurishkuro committed Oct 19, 2023
1 parent b0826a9 commit 4e4d2bc
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions plugin/storage/es/factory_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -303,12 +303,14 @@ func testPasswordFromFile(t *testing.T, f *Factory, getClient func() es.Client,
Servers: []string{server.URL},
LogLevel: "debug",
PasswordFilePath: pwdFile,
BulkSize: -1, // disable bulk; we want immediate flush
}
f.archiveConfig = &escfg.Configuration{
Enabled: true,
Servers: []string{server.URL},
LogLevel: "debug",
PasswordFilePath: pwdFile,
BulkSize: -1, // disable bulk; we want immediate flush
}
require.NoError(t, f.Initialize(metrics.NullFactory, zaptest.NewLogger(t)))
defer f.Close()
Expand Down

0 comments on commit 4e4d2bc

Please sign in to comment.