Skip to content

Commit

Permalink
Remove test summary reports (jaegertracing#5126)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
- Resolves jaegertracing#5114

## Description of the changes
- We had a go at using a test summary reporter github action, but it
appeared to lack sufficient support for "unexpected" test failures such
as panics, while also making it harder to manually inspect test log
output.
- The original log output still satisfies our requirements, as it is
still easy to search through to identify the failing test.

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits

---------

Signed-off-by: Albert Teoh <albert@packsmith.io>
Co-authored-by: Albert Teoh <albert@packsmith.io>
  • Loading branch information
albertteoh and Albert Teoh authored Jan 21, 2024
1 parent adbdb2d commit 6662e1c
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 110 deletions.
31 changes: 0 additions & 31 deletions .github/workflows/ci-unit-tests-go-tip.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,36 +30,5 @@ jobs:
- name: Run unit tests
run: make test-ci

- name: Prepare unit tests report
if: always()
run: make test-report

- name: Publish Unit Test Summary 📑
uses: EnricoMi/publish-unit-test-result-action@v2
if: always()
with:
check_name: Go Tip Unit Tests Summary
junit_files: junit-report.xml
# This workflow isn't run during Pull Requests, so check run and PR comment summaries are not needed.
check_run: false
comment_mode: off

- name: Upload Test Results
if: always()
uses: actions/upload-artifact@v4
with:
name: Test Results
path: junit-report.xml

- name: Lint
run: echo skip linting on Go tip

event-file:
name: "Event File"
runs-on: ubuntu-latest
steps:
- name: Upload
uses: actions/upload-artifact@v4
with:
name: Event File
path: ${{ github.event_path }}
42 changes: 0 additions & 42 deletions .github/workflows/ci-unit-tests-report.yml

This file was deleted.

31 changes: 0 additions & 31 deletions .github/workflows/ci-unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,27 +39,6 @@ jobs:
- name: Run unit tests
run: make test-ci

- name: Prepare unit tests report
if: always()
run: make test-report

- name: Publish Unit Test Summary 📑
uses: EnricoMi/publish-unit-test-result-action@v2
if: always()
with:
check_name: Unit Tests Summary
junit_files: junit-report.xml
# PR comments and check run will be performed by the "Unit Test Results" workflow.
comment_mode: off
check_run: false

- name: Upload Test Results
if: always()
uses: actions/upload-artifact@v4
with:
name: Test Results
path: junit-report.xml

- name: Setup CODECOV_TOKEN
uses: ./.github/actions/setup-codecov

Expand All @@ -71,13 +50,3 @@ jobs:
flags: unittests
fail_ci_if_error: true
token: ${{ env.CODECOV_TOKEN }}

event-file:
name: "Event File"
runs-on: ubuntu-latest
steps:
- name: Upload
uses: actions/upload-artifact@v4
with:
name: Event File
path: ${{ github.event_path }}
7 changes: 1 addition & 6 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,6 @@ draft-release:
install-test-tools:
$(GO) install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.55.2
$(GO) install mvdan.cc/gofumpt@latest
$(GO) install github.com/jstemmer/go-junit-report/v2@latest

.PHONY: install-build-tools
install-build-tools:
Expand All @@ -452,13 +451,9 @@ install-tools: install-test-tools install-build-tools
install-ci: install-test-tools install-build-tools

.PHONY: test-ci
test-ci: GOTEST := $(GOTEST_QUIET) -json
test-ci: GOTEST := $(GOTEST_QUIET)
test-ci: build-examples cover

.PHONY: test-report
test-report:
cat test-results.json | go-junit-report -parser gojson > junit-report.xml

.PHONY: init-submodules
init-submodules:
git submodule update --init --recursive
Expand Down

0 comments on commit 6662e1c

Please sign in to comment.