Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍁 Cache update for private data members + New Unit Test suite #47

Merged
merged 5 commits into from
Jan 24, 2024

Conversation

akashchouhan16
Copy link
Owner

Changelog

  1. Make all data members private.
  2. Access to private cache map disabled. i.e cache.cache is not allowed. The cache is only exposed via the getters and setters.
  3. Updated Configuration setup code change. Cache.config is get only for an instance and it is only exposed via getCacheConfig() api.
  4. Logger configurations are private and only exposed via getLogConfig() api.
  5. Code refactor. Removed bad code and updated unit test cases.

@akashchouhan16 akashchouhan16 added enhancement New feature or request bug-fix labels Jan 24, 2024
Copy link

github-actions bot commented Jan 24, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
92.82% (+1.15% 🔼)
530/571
🟡 Branches
79.85% (-0.3% 🔻)
107/134
🟢 Functions
97.14% (+0.24% 🔼)
136/140
🟢 Lines
92.69% (+1.2% 🔼)
520/561
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / nodecache.configsetup.test.js
100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢 src/nodecache.js
86.61% (+0.76% 🔼)
89.25% (-0.75% 🔻)
82.35% (+2.35% 🔼)
86.61% (+0.76% 🔼)

Test suite run success

65 tests passing in 3 suites.

Report generated by 🧪jest coverage report action from 0b2d81c

@akashchouhan16 akashchouhan16 merged commit 2c3f3f6 into master Jan 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant