Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookstore: initialize project with components #1

Merged
merged 5 commits into from
Oct 13, 2023

Conversation

akbarsazish
Copy link
Owner

1- Add 2 routes in application, each fo them render a page component.
2- Create components inside of the /components directory:
3- Contains individual book state, as well as a button to delete the book
4- Contains a list to renders individual books
5- Contains a form to create new books
6- Contains a navigation to link to the 2 routes created.

Copy link

@ridwanediallo ridwanediallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED 🟢

Hi @akbarsazish ,

Congratulations!GIF

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

(Highlights) Good Points: 👍

  • You documented your work professionally. ✔
  • You used GitHub flow correctly. ✔
  • You successfully completed all the requirements. 🎉 🎉 🎉 ✔

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@akbarsazish
Copy link
Owner Author

@ridwanediallo
Thank you so much for taking the time to review my code. I really appreciate.

@akbarsazish akbarsazish merged commit d17d42d into development Oct 13, 2023
3 checks passed
@akbarsazish akbarsazish deleted the init-component branch October 13, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants