XLS Support

[ryross]

Hey there, I'm digging working with this library. We've run into a situation where we want to load XLS files as well. Obviously, it would be quite a bit of code to write a Spreadsheet Loader for XLS files. I'm wondering if you might consider adding a composer dependency for phpexel in order to automatically convert an xls file to xlsx which we can then use the xlsx parser with. Is that something you'd consider?

[ryross]

I think I'm going to be writing the code to convert the xls to xlsx with phpexcel for my project, and would contribute it to this project, but I don't want to go through the process of tightly integrating it if phpexcel is too big of a dependency to add. To clarify, I'm not asking you to do work, just on if you'd accept a PR with a new dependency.

[jmleroux]

Hello @ryross ,

Including PHPExcel itself is not a problem as long as it is properly loaded only for your converter to not impede the bundle perfs.
And second, i must checks for PHPExcel requirements. I would not accept it if it implies some other requirements like new php extensions or incompatible php versions.

Anyway, thank you for your proposition. That is the open-source way of doing things ! 👍

[jmleroux]

And just let me just some time to check with my teamates for their opinions. ;)

[jmleroux]

After a little bit of search, i found this library: https://github.com/nuovo/spreadsheet-reader

It claims to already read XLS files (with memory warning). Maybe you do not have to rewrite existing code ?