Why autoload won't pass args?

[dezza]

Hello again. I was trying to convert some zsh autoload functions to ble.sh

$ ble-autoload .functions/gpf gpf
$ gpf 1
File-argument ($1) missing

So initially I thought it was because it lacked either a function closure (name() {). But looking at the source it does seem to do what I expect:

ble.sh/src/util.sh

Lines 5254 to 5258 in 3b2b4b8

	builtin eval "function $funcname {
	builtin unset -f $funcname
	ble-import '${file//$q/$Q}' &&
	$funcname \"\$@\"
	}"

I have my own hack for sourcing fpath functions from zsh, this works.

# zsh stub null
emulate() {
  :
}

# emulates zsh fpath
fload() {
  eval "$2 () { $(<$1)"$'\n'" }"
}

Works here:

$ source .functions.bash.sh 
$ fload .functions/gpf gpf
$ gpf 1 # (function executes)

Also.. On second invocation it seems to unset itself.

$ gpf
File-argument ($1) missing
$ gpf
 gpf: command not found

Maybe because ble-import fails second time, for whatever reason?

ble.sh/src/util.sh

Lines 5255 to 5258 in 3b2b4b8

	builtin unset -f $funcname
	ble-import '${file//$q/$Q}' &&
	$funcname \"\$@\"
	}"

[akinomyoga]

# emulates zsh fpath
fload() {
  eval "$2 () { $(<$1)"$'\n'" }"
}

So, you have only the function body directly in the file. This is not the expected usage of ble-autoload.

ble-autoload assumes that the function is defined in the file. In other words, ble-autoload behaves like Zsh's autoload -k, i.e., the ksh-style autoload.

---

So initially I thought it was because it lacked either a function closure (name() {).

Yes, this is the reason.

But looking at the source it does seem to do what I expect:

How do you think so? The generated stub is basically like function gpf { source .functions/gpf && gpf "$@"; }, where gpf is expected to be replaced with the atual implementation by .functions/gpf.

Also.. On second invocation it seems to unset itself.

This is because the loaded file did not define the function gpf.

$ gpf
File-argument ($1) missing

This message is output in the "loading phase", but not by the defined function gpf.

$ gpf
 gpf: command not found

Maybe because ble-import fails second time, for whatever reason?

It is also failing for the first time. The message you saw in the first attempt of calling gpf is output in the loading phase, but not by the actual function gpf.

[dezza]

So initially I thought it was because it lacked either a function closure (name() {).

Yes, this is the reason.

Ahh ok, I misunderstood.. I see, the stub is just for autoloading, not working anything like my POC zsh autoload compat function fload().

I wish on ble-autoload there would be an argument for compat with fpath on zsh (no function signature), this would make transitioning much easier and let you keep the pattern (fpath dir) from zsh in your dotfiles (you don't have to copy the entire fpath dir and add function def to all in a duplicate directory, which is impractical for git repo. Instead they just need to be portable in syntax)

I tried doing file substitution <() into ble-autoload to monkey patch the function signature, but since this is then calling ble-import it doesn't find the fd.

[akinomyoga]

Why don't you use your fload? Or, if you really think it's worth, I can accept in the contrib repository a PR that implements Zsh's autoload emulation. Or you might want to use an example implementation of autoload provided by the official Bash source.

I don't think I would extend ble-autoload.

• The main purpose of ble-autoload is to manage modules of ble.sh, and it defines how the modules should be organized with ble.sh. I'm not going to offer redundant freedom of how the modules should be organized. Also, I actually do not think the fpath approach is a good system; only one function can be defined in one module, or one needs to put as many symbolic links as the public functions defined in each module.
• In addition, with the current interface of ble-autoload, one needs to specify both the filename and the function names, which doesn't suit the fpath system. I'm not going to change or break the existing interface of ble-autoload. The fpath system should rather have a different name than ble-autoload.

[dezza]

Fair point. I will consider the options.

[dezza]

@akinomyoga

I now have:

# fpath compat for ble-autoload / ble-import
bload() {
  local file="$(realpath "$1")"; shift
  local funcname="$(basename $file)"
  local q=\' Q="'\''" funcname
  local ret enc
  ble/util/import/is-loaded "$file" && return 0
  ble/util/import/encode-filename $file; enc=$ret

  builtin eval "$funcname () {
  local ret
  builtin unset -f $funcname
  ble/array#push _ble_util_import_files $file

  ble/util/import/guard:$enc () { return 0; }

  $funcname () { 
    BASH_ARGV0=$file
    $(<$file)
  } &&
    $funcname \"\$@\"
  }"
}

Does this integrate ok?

[akinomyoga]

I feel redundancy with it, but I think it should work.