Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More effect DSL examples in docs #104

Closed
johanandren opened this issue Nov 6, 2023 · 4 comments · Fixed by #125
Closed

More effect DSL examples in docs #104

johanandren opened this issue Nov 6, 2023 · 4 comments · Fixed by #125
Labels
documentation Improvements or additions to documentation

Comments

@johanandren
Copy link
Member

This might be a consequence of me not being familiar enough with rust but I found it hard to understand the various composed effect factory names. When looking at for example warp they have a section on their dsl in the doc start page: https://docs.rs/warp/latest/warp/#filters and then also on individual function pages https://docs.rs/warp/latest/warp/filters/path/index.html

Would be nice if we could do something like that as well, on the landing page, the entity page or maybe the effect page and the individual concrete effect function pages.

@johanandren johanandren added the documentation Improvements or additions to documentation label Nov 6, 2023
@huntc
Copy link
Collaborator

huntc commented Nov 6, 2023

I think a section in the API documentation on the effects would be useful, and so I'll do that.

That said, I think the major thing is to make sure that the commonly used effects are all conveniently discoverable from within your favourite code editor aka the and_then_ ones... and as said in #105, we should perhaps have then_ ones to compliment.

@huntc
Copy link
Collaborator

huntc commented Nov 10, 2023

Are we able to resolve this issue now given the increased doc, and also, the discoverability of the combinators?

@johanandren
Copy link
Member Author

I think it is better and maybe good enough. But I still think that if we could have small snippet showing off effect chains in those docs, like warp has it for their filters, that would be top notch though.

@huntc
Copy link
Collaborator

huntc commented Nov 13, 2023

Okay dokey then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants