Publish to Cloudsmith through Github Actions #60
Conversation
.github/workflows/publish.yml
Outdated
| strategy: | ||
| fail-fast: false | ||
| matrix: # align with publish-test-reports.yml | ||
| SCALA_VERSION: [2.13, 3.3] |
.github/workflows/publish.yml
Outdated
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: # align with publish-test-reports.yml |
There was a problem hiding this comment.
publish-test-reports.yml is probably not relevant here
| @@ -13,4 +13,20 @@ cargo publish -p akka-projection-rs | |||
| cargo publish -p akka-projection-rs-commitlog | |||
| cargo publish -p akka-projection-rs-grpc | |||
| cargo publish -p akka-projection-rs-storage | |||
| ``` | |||
|
|
|||
| ### Publish to Cloudsmith | |||
There was a problem hiding this comment.
note that this will become public source, but I guess it's fine anyway to include these details about Cloudsmith
There was a problem hiding this comment.
I saw we do mention Cloudsmith in akka/akka as well, so I thought its ok.
| env: | ||
| CARGO_REGISTRIES_AKKA_RS_INDEX: https://dl.cloudsmith.io/${{ secrets.CLOUDSMITH_AKKA_RS_ENTITLEMENT_TOKEN }}/lightbend/akka-rs/cargo/index.git | ||
| CARGO_REGISTRIES_AKKA_RS_TOKEN: ${{ secrets.CLOUDSMITH_LIGHTBEND_MACHINE_API_KEY }} | ||
|
|
There was a problem hiding this comment.
One check we could add is to only publish when there is a tag, fail otherwise. Later we want to automate so that this is run automatically when tagging, but for now we will trigger it manually. Good to have that check so that we are not releasing untagged stuff. The tag can be retrieved as in https://github.com/lightbend/akka-edge-rs/blob/main/.github/workflows/release.yml#L59
There was a problem hiding this comment.
I just added the if check, do you think that is sufficient for now?
sebastian-alfers
force-pushed
the
publish-cloudsmith
branch
from
e682d45
to
1d5cf86
Compare
|
I may well be missing something, but how are you going to bump the versions? |
|
I guess if we're going to automate this then it'd be best to to at least validate that the version numbers correspond to the version number indicated by the tag. Also, perhaps an extra note in the |
.github/workflows/publish.yml
Outdated
|
|
||
| steps: | ||
| - name: Checkout | ||
| if: startsWith(github.event.ref, 'refs/tags/v') |
There was a problem hiding this comment.
I don't know how this works, but seems strange that we would be able to check the tag before checkout. We can try and iterate, but I would guess this should be moved to next step.
There was a problem hiding this comment.
also, does this abort steps afterwards or just ignores this step?
Maybe best to place it in Publish?
|
I suggest we merge this with the release workflow that just covers docs so far. |
We can do that when we have automated publishing on tagging, that is the goal. |
No description provided.